Fixed unnecessary playlist version change in SetDefaultKey #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this fix! |
grafov
added a commit
that referenced
this pull request
Aug 22, 2015
Fix unnecessary playlist version change in SetDefaultKey
grafov
added a commit
that referenced
this pull request
Nov 22, 2016
Fix unnecessary playlist version change in SetDefaultKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in the HLS V5 spec:
However any HLS version > 2 is compatible with EXT-X-KEY tags containing only METHOD, URI and IV attributes.
It looks like this behaviour was fixed for the
SetKeyfunction, but notSetDefaultKey. I added the fix toSetDefaultKeyand a couple of tests around it.I also changed the behaviour of
SetDefaultKeyto return anerrorvalue to make it more resembleSetKey