Support test configuration where DynamoDB was never started #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If DynamoDB isn't running, because it was never started, there won't be any PID, and the test cleanup option should simply not do anything. Calling sys.exit makes it impossible to run test configurations that don't start DynamoDB. Fixes grahamar#3
bdarfler
pushed a commit
to localytics/sbt-dynamodb
that referenced
this pull request
Dec 23, 2015
|
Hi, looks like this repo has gone quiet. We've forked it to keep making improvements including merging this PR in. Check it out https://github.com/localytics/sbt-dynamodb/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with issue #3. If you have a test configuration that doesn't start DynamoDB, the plugin will exit hard (sys.exit(1)) when setting up test cleanup. Changed this so that the plugin handles non-running DynamoDB gracefully.