Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document geb, selenium and testcontainers changes #930

Open
jamesfredley opened this issue Dec 14, 2024 · 7 comments · Fixed by #929
Open

document geb, selenium and testcontainers changes #930

jamesfredley opened this issue Dec 14, 2024 · 7 comments · Fixed by #929

Comments

@jamesfredley
Copy link
Contributor

No description provided.

@jamesfredley jamesfredley linked a pull request Dec 14, 2024 that will close this issue
@jamesfredley
Copy link
Contributor Author

@matrei @sbglasius @jdaugherty I'd recommend putting these documentation changes on #929, since it has a ton of other changes for Grails 7.0.0-M1.

@matrei
Copy link
Contributor

matrei commented Dec 16, 2024

I'd recommend putting these documentation changes on #929, since it has a ton of other changes for Grails 7.0.0-M1.

@jamesfredley Roger that!

@jdaugherty
Copy link
Contributor

A lot of the documentation has already been done in the README.md of the geb project. We just need to move it there. @matrei did you want to do this or should I?

@matrei
Copy link
Contributor

matrei commented Dec 16, 2024

@jdaugherty If you have the cycles available, please go ahead. Otherwise, I will try to find time this evening.

@jamesfredley
Copy link
Contributor Author

I think the biggest thing is that users will need a container environment. Might be worth putting something about that in https://github.com/grails/grails-doc/pull/929/files#diff-a274b28b31934a59d9b250f2ff145b5dc95e9a30ba91df2bf3d970853c324aa7

@matrei
Copy link
Contributor

matrei commented Dec 16, 2024

New section added in "What's new": https://github.com/grails/grails-doc/pull/929/files#diff-a274b28b31934a59d9b250f2ff145b5dc95e9a30ba91df2bf3d970853c324aa7

Reviews welcome!

@jamesfredley
Copy link
Contributor Author

@matrei It looks good.

I am going to work through the restoration of the older grails command docs, so I will take care of the sections related to grails-forge cli features.

functionalTesting.adoc and integrationTesting.adoc are the other remaining location with Geb details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants