Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Grails 7 #929

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Update docs for Grails 7 #929

merged 11 commits into from
Dec 20, 2024

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Dec 14, 2024

Prepare grails-docs for Grails 7.0.0-M1

# Conflicts:
#	buildSrc/gradle.properties
#	src/en/guide/introduction/whatsNew/dependencyUpgrades.adoc
@jamesfredley jamesfredley changed the title Pre release 7.0.0 m1 Pre-release 7.0.0-M1 Dec 14, 2024
@jamesfredley jamesfredley linked an issue Dec 14, 2024 that may be closed by this pull request
Copy link
Contributor

@sbglasius sbglasius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion, but otherwise approved

1. A container will be started automatically when you run your integration tests.
2. The container will be configured to launch a browser capable of accessing your application under test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be mentioned, that GebReportingSpec is also replaceable by ContainerGebSpec with the added static boolean reportingSpec = true (I might remember wrong what the prop name is)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an annotation to turn on reporting on ContainerGebSpec now.


The https://github.com/grails/geb[Grails Geb Plugin] has received a significant update, introducing test fixtures that enable ubiquitous containerized browser testing.

This new approach is now the recommended way to write functional tests in Grails. However, the previous method using WebDriver binaries remains supported for backward compatibility.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we support it, isn't the erdi web driver plugin being abandoned? Should we clarify why we containerized this? The largest reason being that because the selenium & browser combination is a moving target, containers allow us to fix to a specific version and not break as browsers are updated over time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Web Driver Plugin limits you to max Gradle 8.6, which limits you to max Java 19. Plus the browser version matching the driver version is a large pain.


The minimum Java version required to run Grails 6 has been updated to Java 11.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are topics in https://github.com/grails/grails-core/blob/7.0.x/UPGRADE7.md that have not made it into the whatsNew document - see the Cool New Features. Should we add them here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% yes.

@jamesfredley
Copy link
Contributor Author

restore grails-shell cli command and profiles documentation: #933, will be merged up after review and approval, and then a few areas can be updated for Grails 7.

@jamesfredley
Copy link
Contributor Author

Moved open feedback to #935

@jamesfredley jamesfredley marked this pull request as ready for review December 20, 2024 03:33
@jamesfredley jamesfredley changed the title Pre-release 7.0.0-M1 Update docs for Grails 7 Dec 20, 2024
@jamesfredley jamesfredley merged commit f448d37 into 7.0.x Dec 20, 2024
2 checks passed
@jamesfredley jamesfredley deleted the pre-release-7.0.0-M1 branch December 20, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants