-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for Grails 7 #929
Conversation
# Conflicts: # buildSrc/gradle.properties # src/en/guide/introduction/whatsNew/dependencyUpgrades.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestion, but otherwise approved
1. A container will be started automatically when you run your integration tests. | ||
2. The container will be configured to launch a browser capable of accessing your application under test. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be mentioned, that GebReportingSpec
is also replaceable by ContainerGebSpec
with the added static boolean reportingSpec = true
(I might remember wrong what the prop name is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an annotation to turn on reporting on ContainerGebSpec now.
|
||
The https://github.com/grails/geb[Grails Geb Plugin] has received a significant update, introducing test fixtures that enable ubiquitous containerized browser testing. | ||
|
||
This new approach is now the recommended way to write functional tests in Grails. However, the previous method using WebDriver binaries remains supported for backward compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we support it, isn't the erdi web driver plugin being abandoned? Should we clarify why we containerized this? The largest reason being that because the selenium & browser combination is a moving target, containers allow us to fix to a specific version and not break as browsers are updated over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Web Driver Plugin limits you to max Gradle 8.6, which limits you to max Java 19. Plus the browser version matching the driver version is a large pain.
|
||
The minimum Java version required to run Grails 6 has been updated to Java 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are topics in https://github.com/grails/grails-core/blob/7.0.x/UPGRADE7.md that have not made it into the whatsNew document - see the Cool New Features. Should we add them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% yes.
restore grails-shell cli command and profiles documentation: #933, will be merged up after review and approval, and then a few areas can be updated for Grails 7. |
Moved open feedback to #935 |
Prepare grails-docs for Grails 7.0.0-M1