-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grails 7: Gradle 8.7+: JCenter retirement breaks webdriver-binaries-gradle-plugin and/or grolifant #443
Comments
We need a new version of com.github.erdi:webdriver-binaries-gradle-plugin that uses a version of grolifant with this change that does not call OperatingSystem.getExecutableName() which was removed in grolifant:3.0.1 |
/** Returns OS-specific decorated exe name.
*
* @param executablePath Name of exe
* @return Returns an appropriately decorated exe
* @deprecated Use{ @link #getExecutableNames(String) } instead
*/
@Deprecated
abstract String getExecutableName(String executablePath) /** Returns list of possible OS-specific decorated exe names.
*
* @param executablePath Name of exe
* @return Returns a list of possible appropriately decorated exes
*/
abstract List<String> getExecutableNames(String executablePath) /** Locates the given exe in the system path.
* @param name Name of exe to search for.
* @return Executable location of {@code null} if not found.
*/
File findInPath(String name) {
for (String exeName : getExecutableNames(name)) {
if (exeName.contains(pathSeparator)) {
File candidate = new File(exeName)
if (candidate.file) {
return candidate
}
} else {
for (File dir : (path)) {
File candidate = new File(dir, exeName)
if (candidate.file) {
return candidate
}
}
}
}
null
} How it was used by the various operating system implementations: |
PR submitted to erdi/webdriver-binaries-gradle-plugin#44 |
jamesfredley
changed the title
JCenter retirement breaks webdriver-binaries-gradle-plugin and/or grolifant
Grails 7: Gradle 8.7+: JCenter retirement breaks webdriver-binaries-gradle-plugin and/or grolifant
Oct 22, 2024
jamesfredley
added a commit
to jamesfredley/grails-website-test
that referenced
this issue
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The work around is to adjust gradle/wrapper/gradle-wrapper.properties to version 8.6.
https://blog.gradle.org/portal-jcenter-impact
This does not appear to occur if you have locally cached versions before the JCenter retirement. github actions caches dependencies also, so they are OK for now.
But on a new environment or if you delete .m2 and .gradle caches you will see this issue.
Current guess is that artifacts on maven central are different than the ones that were on JCenter. Micronaut ran into a similar issue, but they used an older version of web driver and the required jars for that exist on https://repo.grails.org/ui/native/core/org/ysb33r/gradle/grolifant/
The work around is to use Gradle 8.6, before they moved org/gradle/wrapper/ExclusiveFileAccessManager to https://github.com/gradle/gradle/blob/master/platforms/core-runtime/files/src/main/java/org/gradle/internal/file/locking/ExclusiveFileAccessManager.java
Related issues:
erdi/webdriver-binaries-gradle-plugin#43
micronaut-projects/micronaut-core#10988
micronaut-projects/micronaut-core#10990 - micronaut was using an older version of the web driver plugin and the required jars for that exist on https://repo.grails.org/ui/native/core/org/ysb33r/gradle/grolifant/
micronaut was using an older version with different id than grails:
https://plugins.gradle.org/search?term=webdriver-binaries
The text was updated successfully, but these errors were encountered: