fix!: Rework memory management #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2020
|
I will definitely take a 🥃 any day of the week. I also feel like I really need a 🥃 after the debugging to get this working 😂 |
ospencer
added a commit
that referenced
this pull request
Jan 11, 2021
ospencer
added a commit
that referenced
this pull request
Jan 16, 2021
ospencer
added a commit
that referenced
this pull request
Jan 16, 2021
ospencer
added a commit
that referenced
this pull request
Jan 16, 2021
ospencer
added a commit
that referenced
this pull request
Jan 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues we've been having working with large data sets.
Major changes: Grain will now properly grow the WebAssembly memory when out of space. Additionally, a majority of the memory manager has been rewritten from JS into AssemblyScript (which aligns with our goal of removing our dependency on JS).
Minor change: Removed support for garbage collection of cyclic data structures as it caused a major slowdown when trying to reclaim memory from data structures with many children. Grain doesn't (yet) have first-class support for cyclic data structures (see #96), so we don't believe this is a huge issue. If it does become an issue before WebAssembly has its own GC, we'll implement some variation of weak refs.
This is technically a breaking change because
GrainRunneris no longer exported from the runtime. None of our tooling interacts with it directly, though.