fix(cli): Rework JSOO hacks to ensure stdin always gets data #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to have this working out of the box when using node. Tuning the Jsoo runtime should do the trick |
|
Do you want to give it a go and open a PR ? (or at least open an issue) |
|
it seems the patch to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to some amazing detective work by @ng-marcus - we discovered that doing
readSyncon the0file descriptor doesn't always work in node (depending on how values are pushed into stdin); however,readFileSyncon the0file descriptor always works as expected!With this discovery, I reworked the way we workaround JSOO's mock stdin by using their
Sys_js.set_channel_fillerAPI, which then just callsfs.readFileSync(0). Unfortunately, those APIs can't be using in a native build, so I needed to do some dune trickery to concat the workaround to the top ofgrainc.rewhen we are building for JS.I wonder if @hhugo has a better way to handle this. I'm happy to open an issue for cleanup.