[LibOS] Initialize socket handles to be readable and writable #499
Conversation
|
Jenkins, test this please (previous run was successful, just testing some more) |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
|
Jenkins, test this please (previous run was successful, just testing some more) |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
a discussion (no related file):
I tested all examples from https://github.com/gramineproject/examples, except OpenVINO (it downloads too much stuff, I decided to skip it since it shouldn't use sockets anyway). All examples pass fine.
I suggest to wait for other feedback until the end of the day, and if everything is fine, then merge.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
I tested all examples from https://github.com/gramineproject/examples, except OpenVINO (it downloads too much stuff, I decided to skip it since it shouldn't use sockets anyway). All examples pass fine.
I suggest to wait for other feedback until the end of the day, and if everything is fine, then merge.
The PR was tested against a wide set of workloads yesterday, they all passed. This PR is ready for merge.
boryspoplawski
force-pushed
the
borys/rw_sock
branch
from
2f00609 to
3f1601f
Compare
Signed-off-by: Borys Popławski <borysp@invisiblethingslab.com>
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
There was a problem hiding this comment.
Reviewable status:
Description of the changes
This is a temporary fix - rewrite of the whole subsystem is WIP. Hopefully we don't break anything with this...
Fixes #469, fixes #489
This change is