Merge pull request #167 from grammatek/fix/migration_8_9

Fix migration for database version 8->9
grammatek · Apr 24, 2024 · 6f2cba0 · 6f2cba0
2 parents 83595c9 + e19e86b
commit 6f2cba0
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/app/src/main/java/com/grammatek/simaromur/db/ApplicationDb.java b/app/src/main/java/com/grammatek/simaromur/db/ApplicationDb.java
@@ -122,7 +122,8 @@ public void migrate(SupportSQLiteDatabase database){
             Log.v(LOG_TAG, "MIGRATION_8_9");
             // Remove eventually existing table/index
             database.execSQL("DROP TABLE IF EXISTS norm_dict_table");
-            database.execSQL("CREATE TABLE IF NOT EXISTS norm_dict_table (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, `term` TEXT NOT NULL, `replacement` TEXT NOT NULL)");
+            database.execSQL("CREATE TABLE IF NOT EXISTS norm_dict_table (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, `term` TEXT, `replacement` TEXT)");
+            database.execSQL("CREATE UNIQUE INDEX IF NOT EXISTS index_norm_dict_table_term ON norm_dict_table (term ASC)");
         }
     };
 

diff --git a/app/src/test/java/com/grammatek/simaromur/TestRoomDbMigration.java b/app/src/test/java/com/grammatek/simaromur/TestRoomDbMigration.java
@@ -154,6 +154,22 @@ public void migrationFrom7To8NoValidVoicesLeft() throws IOException {
         db.close();
         testHelper.runMigrationsAndValidate(TEST_DB_NAME, 8, true, ApplicationDb.MIGRATION_7_8);
     }
+
+    @Test
+    public void migrationFrom8To9() throws IOException {
+        // Create the database in version 8, then migrate to 9
+        SupportSQLiteDatabase db =
+                testHelper.createDatabase(TEST_DB_NAME, 8);
+        db.execSQL("INSERT INTO app_data_table VALUES (1, '8', 2, 'today', 1, 1)");
+
+        db.execSQL("INSERT INTO voice_table VALUES (1, 'Álfur', 'male', 'Alfur', 'is-IS', 'Íslenska(icelandic)'," +
+                " '', 'network', 'now', 'now', 'http://someurl', 'downloadpath', 'API1', 'nomd5sum', 0)");
+        db.execSQL("INSERT INTO voice_table VALUES (2, 'Steinn', 'male', 'stein_vits_onnx_xs_ipa', 'isl-ISL', 'Íslenska'," +
+                " 'Steinn', 'onnx', 'now', 'now', 'assets', 'is-steinn-xs-ipa.onnx is-steinn-xs-ipa.onnx.json', '0.5', '31a565683d0927cb8a39d5f80ebd85c1', 0)");
+        db.close();
+        testHelper.runMigrationsAndValidate(TEST_DB_NAME, 9, true, ApplicationDb.MIGRATION_8_9);
+    }
+
     @Test
     public void TestDBV2() throws IOException {
         // Create DB in V2
@@ -272,4 +288,19 @@ public void TestDBV8() throws IOException {
 
         db.close();
     }
+
+    @Test
+    public void TestDBV9() throws IOException {
+        // Create DB in V9
+        SupportSQLiteDatabase db =
+                testHelper.createDatabase(TEST_DB_NAME, 9);
+
+        db.execSQL("INSERT INTO voice_table VALUES (1, 'Steinn', 'male', 'stein_vits_onnx_xs_ipa', 'isl-ISL', 'Íslenska'," +
+                " 'Steinn', 'onnx', 'now', 'now', 'assets', 'is-steinn-xs-ipa.onnx is-steinn-xs-ipa.onnx.json', '0.5', '31a565683d0927cb8a39d5f80ebd85c1', 0)");
+
+        db.execSQL("INSERT INTO app_data_table VALUES (1, '8', 1, 'now', 1, 1)");
+        db.execSQL("UPDATE app_data_table SET privacy_info_dialog_accepted = 0, crash_lytics_user_consent_accepted = 0 WHERE appDataId = 1");
+        db.execSQL("INSERT INTO norm_dict_table VALUES (1, 't.d.', 'til dæmis')");
+        db.close();
+    }
 }