Use the voice settings for the pitch. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to the speech rate, there is no setting in e.g. Talkback to change the pitch on-the-fly. Somehow and only for some phones, we get nevertheless strange pitch variations per request and unfortunately cannot trust it. Therefore, restore the previous pitch setting behaviour and use the TTS settings menu pitch value of the phone as has been done before for Símarómur versions 2.0.2 and earlier. See also issue #24 Signed-off-by: Daniel Schnell <dschnell@grammatek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to the speech rate, there is no setting in e.g. Talkback to change the pitch on-the-fly.
Somehow and only for some phones, we get nevertheless strange pitch variations per request and unfortunately cannot trust it. Therefore, restore the previous pitch setting behaviour and use the TTS settings menu pitch value of the phone as has been done before for Símarómur versions 2.0.2 and earlier.
See also issue #24