-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set up killProcess to ensure PhantomJS is stopped, including children
It seems that `proc_terminate` doesn't reliably shut down child processes, especially in Windows. A new method of `killProcess` has been set up that will use Windows specific `taskkill` and Unix's `kill` to stop the process and its children. This in the aim to resolve issue #20 and to mitigate issue #25.
- Loading branch information
1 parent
962f2de
commit 3834f37
Showing
1 changed file
with
26 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters