Add exported IsNullable method to nullable types #442
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was very happy to see #430 merged and am now using it. However, in my project, I felt that having an exported
IsNullable
method would be useful, especially when implementingNullable
custom scalar types.This will allow one to verify that custom
Nullable
implementations correctly implement theNullUnmarshaller
interface.It also allows us to verify the type of the input field for things like gRPC field masks.
E.g., previously, if one had a traditional nullable field, we would not be able to generate gRPC field masks accurately for partial updates because if a field was
nil
we would not add the field mask. Now, users can check if a fieldIsNullable
, and if it is, check if theSet
field istrue
orfalse
, in order to set a field mask accurately.Hopefully this method is safe to export; it would be helpful for our project and I hope it will be useful to others who want to take advantage of the new Nullable functionality.