-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for repeatable directives #502
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
282a0b4
add support for repeatable directives
speezepearson 807fd0d
test: improve tests around `repeatable` keyword
speezepearson 6d69b7d
fix: actually set Directive.Repeatable
speezepearson ea5bb88
make case statement more explicit
speezepearson 44145ba
clarify error when `on` keyword is repeated in directive definition
speezepearson e213b62
replace no-op instruction with comment
speezepearson 8064827
refactor: rename scalar in test
speezepearson 1feb03c
reword: "iff" -> "if"
speezepearson 10dda97
refactor: enumerate legal field locations, rather than regexp-matching
speezepearson fef2bb3
Revert "refactor: enumerate legal field locations, rather than regexp…
speezepearson 16a6f67
tweak regexp
speezepearson 7a1dc0d
Revert "Revert "refactor: enumerate legal field locations, rather tha…
speezepearson 0681250
rename
speezepearson 05a893c
fixup: remove unnecessary if-stmt
speezepearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you explicitly consume keyword
on
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on
got consumed by theConsumeIdent()
on the previous line, didn't it? Looking at the implementations ofConsumeIdent
/ConsumeKeyword
, it looks like they both callTokenText()
and thenConsumeWhitespace()
, so I expect they will consume the same number of tokens; and if this code didn't consumeon
, then I would expecton
to be interpreted as the location, which would make this check fail in this test.