Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.1 and 7.2 to travis.yml. #31

Closed

Conversation

tomzx
Copy link

@tomzx tomzx commented Jun 9, 2018

I'm not sure what your policy is about supporting EOL PHP versions, but I'd suggest simply not doing so.

@tomzx tomzx force-pushed the features/add-php-versions-to-travis branch from d4d6eb1 to 12921f3 Compare June 9, 2018 02:09
Remove all versions that are not actively supported.
@tomzx tomzx force-pushed the features/add-php-versions-to-travis branch from 12921f3 to aeecd60 Compare June 9, 2018 02:16
@tomzx tomzx changed the title Add PHP 7.0, 7.1 and 7.2 to travis.yml. Add PHP 7.1 and 7.2 to travis.yml. Jun 9, 2018
@phyrwork
Copy link
Contributor

phyrwork commented Jun 9, 2018

I agree that it's time to drop support for PHP 5.

And as far as I can tell there shouldn't be any compatibility issues with PHP 7 - at least all my applications of the library have functioned without issue.

Commit looks fine to me.

@clue
Copy link
Member

clue commented Sep 28, 2018

@tomzx Thank you for filing this PR! I've just merged #32 which supersedes this PR by adding support for latest PHP versions without removing legacy versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants