Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append a Walk to another one #112

Closed
wants to merge 1 commit into from
Closed

Append a Walk to another one #112

wants to merge 1 commit into from

Conversation

dav-m85
Copy link

@dav-m85 dav-m85 commented Nov 30, 2014

No description provided.

@@ -310,4 +310,25 @@ public function isValid()

return true;
}

/**
* @param Walk $walk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docblock needs an update, see also following remarks :)

@clue
Copy link
Member

clue commented Mar 4, 2015

Great suggestion and thanks for your patience! :)

Now with all my remarks in place, let me stress that I'd still love to see this in! 👍

@clue
Copy link
Member

clue commented Apr 21, 2015

Ping @dav-m85, perhaps you can use some support so that we can get this in? :)

@clue
Copy link
Member

clue commented Sep 29, 2018

Again, thank you for digging into this and filing this PRs! 👍

I still think that getting this feature in makes perfect sense and I'm looking forward to a future update here!

Given that this is currently a WIP and hasn't seen any updates in a while and I don't see it's likely this will get traction any time soon, I will have to close this for now. Please don't see this as discouraging, we would still love to get this feature in and very much appreciate your effort! You can simply complete this feature and update this PR and we're happy to reopen this 👍

@clue clue closed this Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants