Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creating edges to Graph #175

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Move creating edges to Graph #175

merged 1 commit into from
Oct 4, 2019

Conversation

clue
Copy link
Member

@clue clue commented Oct 3, 2019

The new API is now much more consistent with all other create*()
methods and makes the distinction between undirected and directed edges
more explicit:

// old
$v1->createEdge($v2);
$v1->createEdgeTo($v2);

// new
$graph->createEdgeUndirected($v1, $v2);
$graph->createEdgeDirected($v1, $v2);

The new API is now much more consistent with all other `create*()`
methods and makes the distinction between undirected and directed edges
more explicit:

```
// old
$v1->createEdge($v2);
$v1->createEdgeTo($v2);

// new
$graph->createEdgeUndirected($v1, $v2);
$graph->createEdgeDirected($v1, $v2);
```
@clue clue added this to the v1.0.0 milestone Oct 3, 2019
@clue clue merged commit 9ce805c into graphp:master Oct 4, 2019
@clue clue deleted the createedge branch October 4, 2019 09:53
clue added a commit to clue-labs/graphviz that referenced this pull request Jan 8, 2020
clue added a commit to clue-labs/algorithms that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant