-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update test command to reflect new matchstick version #1470
Conversation
🦋 Changeset detectedLatest commit: 8c1e2a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e11f2c9
to
123f0f3
Compare
package.json
Outdated
@@ -36,7 +36,8 @@ | |||
"babel-jest": "^29.3.1", | |||
"eslint": "8.48.0", | |||
"jest": "29.7.0", | |||
"prettier": "3.0.3" | |||
"prettier": "3.0.3", | |||
"semver": "^7.5.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be a global dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, still getting used to pnpm
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saihaj should be good now
0fc7d65
to
b4f5289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
With the recent release of Matchtick 0.6.0-rc.3 and upcoming release of 0.6.0, the test command should be updated to drop support for certain versions of MacOS and Ubuntu (mentioned in the release notes), for Matchstick versions later than
0.5.4
. For previous versions, the flow should remain the same.