Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update test command to reflect new matchstick version #1470

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

pete-eiger
Copy link
Contributor

@pete-eiger pete-eiger commented Sep 27, 2023

With the recent release of Matchtick 0.6.0-rc.3 and upcoming release of 0.6.0, the test command should be updated to drop support for certain versions of MacOS and Ubuntu (mentioned in the release notes), for Matchstick versions later than 0.5.4. For previous versions, the flow should remain the same.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 8c1e2a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphprotocol/graph-cli Patch
lens-protocol-posts-sg Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pete-eiger pete-eiger force-pushed the main branch 6 times, most recently from e11f2c9 to 123f0f3 Compare September 27, 2023 10:29
@pete-eiger pete-eiger marked this pull request as ready for review September 27, 2023 10:33
package.json Outdated
@@ -36,7 +36,8 @@
"babel-jest": "^29.3.1",
"eslint": "8.48.0",
"jest": "29.7.0",
"prettier": "3.0.3"
"prettier": "3.0.3",
"semver": "^7.5.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be a global dep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, still getting used to pnpm 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saihaj should be good now

@pete-eiger pete-eiger force-pushed the main branch 3 times, most recently from 0fc7d65 to b4f5289 Compare September 27, 2023 19:24
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@saihaj saihaj merged commit 4c1ca35 into graphprotocol:main Sep 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants