Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --skip-git option to init cli command #1531

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

travs
Copy link
Contributor

@travs travs commented Dec 6, 2023

Automating git commands inside a script or cli tool can lead to confusing and unwanted behaviour.

This PR allows the user to skip git automation when initing a new subgraph.
Personally I think the git automation should be opt-in instead of the default, but I left the default behaviour as-is for an easy merge.

Related:

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 1658fcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I was also thinking today about adding someway to disallow git, maybe in next major we should not init git default and have users pass in a flag

@saihaj saihaj enabled auto-merge (squash) December 6, 2023 17:24
@saihaj saihaj merged commit b168be1 into graphprotocol:main Dec 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants