Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph add Etherscan lookups when using localhost network #1751

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

0237h
Copy link
Collaborator

@0237h 0237h commented Oct 30, 2024

The command will now skip Etherscan lookups if detecting the network as localhost. User will be prompted to enter all relevant information.

Before

screenshot_2024-10-30_17-21-50

After

screenshot_2024-10-30_17-20-54

Closes #1748

The command will now skip Etherscan lookups if detecting the network
as `localhost`. User will be prompted to enter all relevant information.

Closes graphprotocol#1748
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: e1d91f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0237h 0237h requested a review from YaroShkvorets October 30, 2024 21:19
@0237h 0237h marked this pull request as ready for review October 30, 2024 21:23
@0237h 0237h merged commit 0ba99dc into graphprotocol:main Oct 31, 2024
9 checks passed
@0237h 0237h deleted the fix/graph-add-localhost-network branch October 31, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph add errors with getaddrinfo ENOTFOUND api-localhost.etherscan.io on localhost
2 participants