Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isNullish to not consider an empty string as Null. #228

Merged
merged 2 commits into from
Aug 5, 2017
Merged

Fix isNullish to not consider an empty string as Null. #228

merged 2 commits into from
Aug 5, 2017

Commits on Aug 5, 2017

  1. Fix isNullish to not consider an empty string as Null. 

    An empty string is still a perfectly valid string, in both situations:
(1) An empty string is a valid string argument to a handler.
(2) An empty string is a valid non-null result from a handler.

I also removed the unused and unnecessary PrivateName value from the
NonNull struct -- it served no purpose and screwed up tests when isNullish
was fixed.
    @augustoroman @chris-ramon
    augustoroman authored and chris-ramon committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    5425913 View commit details
    Browse the repository at this point in the history

  2. empty string fixes

    @chris-ramon
    chris-ramon committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    2ddab1a View commit details
    Browse the repository at this point in the history