Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't format the error message unless it is really needed #267

Merged
merged 2 commits into from
Jan 7, 2018
Merged

Don't format the error message unless it is really needed #267

merged 2 commits into from
Jan 7, 2018

Conversation

fd
Copy link
Contributor

@fd fd commented Jan 5, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jan 5, 2018

Coverage Status

Coverage increased (+0.009%) to 82.234% when pulling b16d2fd on mrhenry:lazy-invariant into 9b5a661 on graphql-go:master.

@fd
Copy link
Contributor Author

fd commented Jan 7, 2018

benchmark                       old ns/op       new ns/op      delta
BenchmarkListQuery_1-4          349864          243236         -30.48%
BenchmarkListQuery_100-4        3534198         1586335        -55.11%
BenchmarkListQuery_1K-4         32966933        13725420       -58.37%
BenchmarkListQuery_10K-4        308862819       140592678      -54.48%
BenchmarkListQuery_100K-4       2255458560      981282854      -56.49%
BenchmarkWideQuery_1_1-4        159626          140584         -11.93%
BenchmarkWideQuery_10_1-4       960218          582556         -39.33%
BenchmarkWideQuery_100_1-4      62290987        30767558       -50.61%
BenchmarkWideQuery_1K_1-4       6342374529      2840497529     -55.21%
BenchmarkWideQuery_1_10-4       196672          170694         -13.21%
BenchmarkWideQuery_10_10-4      2356517         1197957        -49.16%
BenchmarkWideQuery_100_10-4     190874887       78918530       -58.65%
BenchmarkWideQuery_1K_10-4      20784765533     8915631619     -57.10%

@coveralls
Copy link

coveralls commented Jan 7, 2018

Coverage Status

Coverage decreased (-0.02%) to 82.23% when pulling d951837 on mrhenry:lazy-invariant into 77b1ae5 on graphql-go:master.

@chris-ramon
Copy link
Member

pretty awesome!, thanks @fd 🚢

@chris-ramon chris-ramon merged commit 363d9c3 into graphql-go:master Jan 7, 2018
@romainmenke romainmenke deleted the lazy-invariant branch January 7, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants