Scalar nil pointer safety #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfriedel
force-pushed
the
scalar-nil-pointer-safety
branch
from
1fe14c0
to
986ca8b
Compare
|
Thanks lot @sfriedel! this is definitely a great improvement, now it won't bite us again since you added tests for it. 🛡️ 🚢 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression when trying to serialize nil pointer values in scalars reported in #365.
The regression was introduced by the merge of #363 because previously the panic in the coercion functions was ignored in
completeValueCatchingErrorand set the field to nil/null.The change introduces explicit handling for the nil pointers in the scalar coercion functions to prevent the panic from happening.