Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unserialization of time.Time instance #523

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Support unserialization of time.Time instance #523

merged 2 commits into from
Nov 25, 2019

Conversation

asaf
Copy link

@asaf asaf commented Oct 28, 2019

Fixes #522

@coveralls
Copy link

coveralls commented Oct 28, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 92.344% when pulling 05d6d76 on asaf:dateTimeUnserializationTimeInstanceFix into 14904e6 on graphql-go:master.

@chris-ramon chris-ramon self-requested a review November 25, 2019 02:08
@chris-ramon
Copy link
Member

LGTM 👍 –– Thanks a lot @asaf 🚢 💯

@chris-ramon chris-ramon merged commit 2e2b648 into graphql-go:master Nov 25, 2019
@asaf
Copy link
Author

asaf commented Nov 25, 2019

@chris-ramon with lots of love :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-ramon chris-ramon chris-ramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to parse time.Time instance
3 participants
@asaf @coveralls @chris-ramon