cli: prevent reading a key of undefined value from config file

graphql-hive · Jul 13, 2023 · 8071969 · 8071969
1 parent f41f5fa
commit 8071969
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/dirty-adults-clap.md b/.changeset/dirty-adults-clap.md
@@ -0,0 +1,5 @@
+---
+'@graphql-hive/cli': patch
+---
+
+prevent reading a key of undefined value from config file
diff --git a/packages/libraries/cli/src/helpers/config.ts b/packages/libraries/cli/src/helpers/config.ts
@@ -108,12 +108,18 @@ export class Config {
     }
   }
 
-  get<TKey extends ValidConfigurationKeys>(key: TKey): GetZodValueType<TKey, typeof ConfigModel> {
+  get<TKey extends ValidConfigurationKeys>(
+    key: TKey,
+  ): GetZodValueType<TKey, typeof ConfigModel> | null {
     const map = this.read();
 
     const parts = key.split('.');
     let current: any = map;
     for (const part of parts) {
+      if (current == null) {
+        return null;
+      }
+
       current = current[part];
     }