fix: #921 wrong typegen for nullable values w/ default #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgriesser
added a commit
that referenced
this pull request
Sep 2, 2021
* main: feat: ability to rename root types (#976) docs: Remove `.ts` extension from import statement (#974) fix: revert declareInputs default to false (#975) fix: printer imports, follow up from #967 (#970) fix: plugin inputFieldDefTypes (#919) fix: add globalHeaders to imports for global def file (#969) fix: correct imports for changes in #967 (#968) feat: ConfiguredTypegen for splitting global types & configuring input type emission (#967) Revert "fix: #921 wrong typegen for nullable values w/ default (#965)" (#966) fix: #921 wrong typegen for nullable values w/ default (#965)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #921
Incorrect logic in the type printer, if the input field has a default value it should not be required