refactor: More internal cleanup #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgriesser
commented
Sep 3, 2021
tgriesser
commented
- Add Maybe on resolveType to match GraphQL signature
- Don't create placeholder Query type when renamed
- Internal rename rootTypings -> sourceTypings
- Add Maybe on resolveType to match GraphQL signature - Don't create placeholder Query type when renamed - Internal rename rootTypings -> sourceTypings
tgriesser
added a commit
that referenced
this pull request
Feb 16, 2022
* main: chore(docs): fix typos (#1005) chore(docs): fix typo 06-chapter-5-persisting-data-via-prisma.mdx (#1007) chore(docs): fix typo 04-why-nexus.mdx (#1008) chore(docs): fix typo 030-neuxs-framework-prisma-users.mdx (#1016) chore(docs): fix typo 05-chapter-4-testing-your-api.mdx (#1023) chore(docs): fix typo in 07-chapter-6-testing-with-prisma.mdx (#1024) fix: Minimum GraphQL v16 support (#1017) chore(docs): add Example Code (#948) chore(docs): Update Ordering section (#950) chore(docs): Nexus Getting started: missing type in queryType (#995) chore(docs): readme update -- fix code sample to include ".ts" in module path (#998) chore(docs): typo fix in docs (#999) chore(docs): change package get-port ver in tutorial (#1000) docs: change all "npm add" to "npm install" (#991) docs: Update 061-list-nonNull.mdx (#986) feat: Add mergeSchema, better graphql-js interop (#983) refactor: More internal cleanup (#981) refactor: Internal type cleanup (#980) refactor: remove duplicate core schema type checks (#978)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.