Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poetry installation (newline in description) #180

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix poetry installation (newline in description) #180

merged 1 commit into from
Sep 7, 2022

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Sep 5, 2022

$ poetry install .

The Poetry configuration is invalid:
  - [description] 'GraphQL-core is a Python port of GraphQL.js,\n the JavaScript reference implementation for GraphQL.' does not match '^[^\n]*$'

fixes relates to #178
relates to Homebrew/homebrew-core#109642

Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. I think it suffices to put a backslash after the comma, can you try that out? I'd like to avoid overly long lines.

@chenrui333
Copy link
Contributor Author

yeah, totally

@chenrui333 chenrui333 requested a review from Cito September 6, 2022 13:32
@chenrui333
Copy link
Contributor Author

that works, just refreshed the PR. thanks!

Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, but I think you can actually remove the first backslash. The string is left-trimmed automatically. At least I think so. Can you check that as well?

@chenrui333
Copy link
Contributor Author

yeah, you are right, only backslash is needed

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Contributor Author

let me know if anything else needed.

@Cito Cito merged commit 0c0f180 into graphql-python:main Sep 7, 2022
@Cito Cito changed the title fix poetry installation Fix poetry installation (newline in description) Sep 7, 2022
@Cito
Copy link
Member

Cito commented Sep 7, 2022

Thanks for contributing. Will try to cut a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants