Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add codspeed for continuous benchmarking #230

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

erikwrede
Copy link
Member

@erikwrede erikwrede commented Oct 19, 2024

This PR adds CodSpeed for benchmarking

@erikwrede erikwrede requested a review from Cito as a code owner October 19, 2024 11:14
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 14 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_execute_async_iterable_list_field (12 ms)
  • test_build_schema_from_ast (109.7 ms)
  • test_build_schema_from_introspection (127.2 ms)
  • test_execute_basic_async (2.8 ms)
  • test_execute_basic_sync (2.7 ms)
  • test_recreate_a_graphql_schema (13.5 ms)
  • test_execute_introspection_query (820 ms)
  • test_parse_kitchen_sink (7.4 ms)
  • test_many_repeated_fields (650.8 ms)
  • test_validate_introspection_query (15.6 ms)
  • test_validate_invalid_query (188.5 ms)
  • test_validate_sdl_document (454.6 ms)
  • test_visit_all_ast_nodes (213.1 ms)
  • test_visit_all_ast_nodes_in_parallel (1.5 s)

Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. I have made two comments. I'd also move it into a separate yml file.

You can ignore the mypy issues since they are not related to the PR, I fill fix them in main.

tests/benchmarks/test_visit.py Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@Cito Cito merged commit 0d573da into graphql-python:main Oct 21, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants