codegen: improve error messages #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial step. Further improvements could offer suggestions for what is available. See graphql-rust#97.
mathstuf
force-pushed
the
improve-error-messages
branch
from
9920c1d to
a09cb23
Compare
tomhoule
approved these changes
Sep 11, 2018
| object | ||
| } else { | ||
| panic!("fragment '{}' cannot operate on unknown type '{}'", self.name, self.on); | ||
| }; |
There was a problem hiding this comment.
That's a lot better - I forgot we still had error messages as bad as the original one :/
There was a problem hiding this comment.
Well, it was easy to grep for to replace when I hit it :) .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial step. Further improvements could offer suggestions
for what is available.
See #97.