Use actix-ws
for juniper_actix
subscriptions
#1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1191, #1186
Motivation
See #1186 (comment):
Also, WebSocket connections are not closed normally in
juniper_actix
, due to panics:Solution
Get rid of
actix-web-actors::ws
and useactix-ws
crate instead.Now, WebSocket connections are closing as expected:
Additionally
graphql-transport-ws
implementation, regarding panicking for edge cases in polling.juniper::http
integration tests forgraphql-transport-ws
as well.