Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fallback to hosted js files without cdn #135

Closed
ofbeaton opened this issue May 12, 2016 · 4 comments
Closed

Allow fallback to hosted js files without cdn #135

ofbeaton opened this issue May 12, 2016 · 4 comments

Comments

@ofbeaton
Copy link

Tried to use graphiql on an intranet without an internet connection, horrible experience, everything is loaded from cdn.

Similar issues in other flavours of graphiql, seems like I'm not the only one having this issue.
expo/koa-graphiql#1

Could we have a fallback where if the cdn fails to load the files it loads a local copy?

@dolphin278
Copy link

dolphin278 commented May 16, 2016

Right now jsdelivr went down, suffering from DDoS attack so GraphiQL became completely unavailable :(

https://twitter.com/jsDelivr/status/732245796066852864

@asiandrummer
Copy link
Contributor

Good suggestion @ofbeaton - a fallback local copy makes sense to me.

@ofbeaton
Copy link
Author

Perhaps something similar to what the initializr template recommends for jquery?

<script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script>
<script>window.jQuery || document.write('<script src="js/vendor/jquery.min.js') }}"><\/script>')</script>

@asiandrummer
Copy link
Contributor

Sorry I've been super late with this - 236591 adds the fallback to the local copies. Thanks for the suggestion!

acao pushed a commit to acao/graphiql that referenced this issue Jun 1, 2019
acao pushed a commit to acao/graphiql that referenced this issue Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants