-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix project references, upgrade @types/graphql #2497
base: main
Are you sure you want to change the base?
Conversation
|
The latest changes of this PR are not available as canary, since there are no linked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up some of my oversights 🙏 Do we even need to keep vite
as dependency for @graphiql/react
for now then? Or should we kick it out and as you said iterate over the build process for the whole monorepo later?
@thomasheyenbrock hey no worries! I wish I had more time outside of work to help review all of this! I might just apply for a graphql grant so I can keep up haha. These kinds of oversights are the kind of adaptations you need to make when the tooling isn't well documented or organized, like this repo! Also project references are a bit esoteric, especially the per-workspace I think we can leave it there for now, but move the vite build to There is supposed to be a way to tweak the webpack config (and likely also the vite/rollup config) where it just resolves the source files and compiles on it's own, but I think we had issues with that (led to inconsistencies between the npm package and the cdn bundle if i recall? worth a revisit!) Also, what is the command/are the comands you're using for graphiql development? Currently |
Bahhh... so many errors when I try to rectify this... I apologise, this build tooling is such a house of cards. |
this consolidates & simplifies the tsconfig project references tree and build steps, so that we have a proper cross-repository incremental build!
now if you run
yarn tsc --watch
, you'll get an incremental build of the entire repository, where only the changes you make incur a new build.this will tide us over until we figure out how to use esbuild/vite together with references happily, or replace project references with another incremental build tool
build:watch
foryarn tsc --watch
concurrently
andyarn build:watch
tostart-graphiql