Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a lint diagnostic from invalid schema #3463

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

imolorhe
Copy link
Contributor

Create a lint diagnostic from invalid schema
Follow up from #3461

Copy link

changeset-bot bot commented Nov 18, 2023

🦋 Changeset detected

Latest commit: a6e5f6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cm6-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imolorhe imolorhe requested a review from acao November 18, 2023 11:39
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #3463 (a6e5f6e) into main (2348641) will increase coverage by 0.10%.
Report is 30 commits behind head on main.
The diff coverage is 79.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3463      +/-   ##
==========================================
+ Coverage   55.75%   55.85%   +0.10%     
==========================================
  Files         110      110              
  Lines        5243     5264      +21     
  Branches     1426     1435       +9     
==========================================
+ Hits         2923     2940      +17     
- Misses       1897     1898       +1     
- Partials      423      426       +3     
Files Coverage Δ
packages/graphiql-react/src/editor/context.tsx 73.39% <100.00%> (ø)
...raphql-language-service-server/src/GraphQLCache.ts 50.88% <50.00%> (ø)
...ql-language-service-server/src/MessageProcessor.ts 46.11% <50.00%> (-0.11%) ⬇️
...nguage-service/src/utils/getVariablesJSONSchema.ts 94.59% <98.38%> (+0.71%) ⬆️
packages/graphiql/src/components/GraphiQL.tsx 68.96% <0.00%> (-0.97%) ⬇️
packages/graphiql-react/src/editor/hooks.ts 40.15% <23.52%> (+1.56%) ⬆️

Copy link
Contributor

github-actions bot commented Nov 18, 2023

The latest changes of this PR are available as canary in npm (based on the declared changesets):

cm6-graphql@0.0.12-canary-7c65cc76.0

Copy link
Member

@acao acao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all makes sense to me, thanks @imolorhe !

yes I would assume the schema error should be present by default. this should only need to be disabled when, for example, someone is making a new spec proposal, or perhaps when building a schema server from scratch and experimenting with the introspection response and you want to reduce the noise

@acao acao merged commit e45ba17 into main Nov 20, 2023
14 checks passed
@acao acao deleted the imolorhe/lint-error-for-validate-schema branch November 20, 2023 12:29
@acao acao mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants