-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a lint diagnostic from invalid schema #3463
Conversation
🦋 Changeset detectedLatest commit: a6e5f6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3463 +/- ##
==========================================
+ Coverage 55.75% 55.85% +0.10%
==========================================
Files 110 110
Lines 5243 5264 +21
Branches 1426 1435 +9
==========================================
+ Hits 2923 2940 +17
- Misses 1897 1898 +1
- Partials 423 426 +3
|
The latest changes of this PR are available as canary in npm (based on the declared
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all makes sense to me, thanks @imolorhe !
yes I would assume the schema error should be present by default. this should only need to be disabled when, for example, someone is making a new spec proposal, or perhaps when building a schema server from scratch and experimenting with the introspection response and you want to reduce the noise
Create a lint diagnostic from invalid schema
Follow up from #3461