Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] prefer location over window.location and prefer navigator over window.navigator #3692

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 859bd5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphiql/react Patch
graphiql Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.86%. Comparing base (d34246e) to head (859bd5f).

Files Patch % Lines
packages/graphiql-react/src/editor/common.ts 66.66% 0 Missing and 1 partial ⚠️
packages/graphiql/src/components/GraphiQL.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           graphiql-v4    #3692      +/-   ##
===============================================
+ Coverage        60.84%   60.86%   +0.02%     
===============================================
  Files              121      121              
  Lines             5618     5614       -4     
  Branches          1488     1488              
===============================================
- Hits              3418     3417       -1     
+ Misses            1748     1746       -2     
+ Partials           452      451       -1     
Files Coverage Δ
...hiql-react/src/editor/components/image-preview.tsx 3.44% <ø> (+0.22%) ⬆️
packages/graphiql-react/src/editor/common.ts 80.00% <66.66%> (+5.00%) ⬆️
packages/graphiql/src/components/GraphiQL.tsx 67.32% <0.00%> (ø)

Copy link
Contributor

github-actions bot commented Aug 7, 2024

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@dimaMachina dimaMachina merged commit 82bc961 into graphiql-v4 Aug 7, 2024
14 checks passed
@dimaMachina dimaMachina deleted the prefer-location-navigator branch August 7, 2024 22:58
@acao acao mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant