migrate @graphiql/toolkit to tsup
#3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5b118a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
commented
Aug 23, 2024
Comment on lines
-19
to
+22
| let httpFetch; | ||
| if (typeof window !== 'undefined' && window.fetch) { | ||
| httpFetch = window.fetch; | ||
| } | ||
| if ( | ||
| options?.enableIncrementalDelivery === null || | ||
| options.enableIncrementalDelivery !== false | ||
| ) { | ||
| options.enableIncrementalDelivery = true; | ||
| } | ||
| if (options.fetch) { | ||
| httpFetch = options.fetch; | ||
| } | ||
| const httpFetch = | ||
| options.fetch || (typeof window !== 'undefined' && window.fetch); | ||
| if (!httpFetch) { | ||
| throw new Error('No valid fetcher implementation available'); | ||
| } | ||
| options.enableIncrementalDelivery = | ||
| options.enableIncrementalDelivery !== false; |
There was a problem hiding this comment.
simplified these parts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3746 +/- ##
==========================================
- Coverage 67.29% 67.24% -0.05%
==========================================
Files 121 121
Lines 7017 7007 -10
Branches 2269 2259 -10
==========================================
- Hits 4722 4712 -10
Misses 2278 2278
Partials 17 17
|
|
The latest changes of this PR are available as canary in npm (based on the declared |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make package independent from
tscwith owndev/buildscripts, will be possible to fix #3668 later