-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/2] [@graphiql/react] compile source code with react-compiler, remove useMemo
and useCallback
usages
#3821
Conversation
🦋 Changeset detectedLatest commit: 24c8c1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e44ced9
to
e1b3cc5
Compare
The latest changes of this PR are available as canary in npm (based on the declared
|
@dimaMachina any chance this can happen against the v4 branch? will it be hard to adopt these changes to the v4 branch? |
@acao I think folks can already benefit from this improvement even in v3? see how react-compiler improved Nextra 😅 Screen.Recording.2024-12-10.at.22.30.38.mov |
useMemo
and useCallback
usagesuseMemo
and useCallback
usages
useMemo
and useCallback
usagesuseMemo
and useCallback
usages
So many commits with meaningless comments. |
const isFocused = useRef(false); | ||
const handleFocus: FocusEventHandler = useCallback(e => { | ||
isFocused.current = e.type === 'focus'; | ||
}, []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Was there a reason to remove this? This might be related to the following regression: #3842
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it's still present
graphiql/packages/graphiql-react/src/explorer/components/search.tsx
Lines 60 to 62 in 1d598a9
const handleFocus: FocusEventHandler = e => { | |
setIsFocused(e.type === 'focus'); | |
}; |
I will take a look at your issue soon!
No description provided.