[v3] migrate graphiql to vite and react compiler #3826
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'graphiql': minor | ||
| --- | ||
|
|
||
| migrate `graphiql` to `vite` and `react compiler` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| // @ts-expect-error -- fixme | ||
| export default (on, config) => { | ||
| return config; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/resources/logo.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>GraphiQL</title> | ||
| <style> | ||
| body { | ||
| margin: 0; | ||
| overflow: hidden; /* in Firefox */ | ||
| } | ||
|
|
||
| #graphiql { | ||
| height: 100dvh; | ||
| } | ||
|
|
||
| .loading { | ||
| height: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| font-size: 4rem; | ||
| } | ||
| </style> | ||
| <!--vite-replace-start--> | ||
| <script | ||
| crossorigin | ||
| src="https://unpkg.com/react@18/umd/react.production.min.js" | ||
| ></script> | ||
| <script | ||
| crossorigin | ||
| src="https://unpkg.com/react-dom@18/umd/react-dom.production.min.js" | ||
| ></script> | ||
| <script src="/dist/index.umd.js"></script> | ||
| <link href="/dist/style.css" rel="stylesheet" /> | ||
| <!--vite-replace-end--> | ||
| </head> | ||
| <body> | ||
| <div id="graphiql"> | ||
| <div class="loading">Loading…</div> | ||
| </div> | ||
| <script type="module" src="resources/renderExample.js"></script> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,37 +17,39 @@ | |
| }, | ||
| "license": "MIT", | ||
| "main": "dist/index.js", | ||
| "module": "dist/index.mjs", | ||
| "types": "dist/index.d.ts", | ||
| "files": [ | ||
| "dist", | ||
| "graphiql.js", | ||
| "graphiql.min.js", | ||
| "graphiql.min.js.map", | ||
| "graphiql.css", | ||
| "graphiql.min.css" | ||
| ], | ||
| "exports": { | ||
| "./package.json": "./package.json", | ||
| "./style.css": "./dist/style.css", | ||
| "./graphiql.css": "./dist/style.css", | ||
|
There was a problem hiding this comment. exports don't work with jsdelivr/unpkg unfortunately, we must publish to npm with these exact files There was a problem hiding this comment. this is for backward compatibility since I added I added graphiql/packages/graphiql/package.json Line 48 in ad75cda |
||
| ".": { | ||
| "require": "./dist/index.js", | ||
| "import": "./dist/index.mjs", | ||
| "types": "./dist/index.d.ts" | ||
| } | ||
| }, | ||
| "scripts": { | ||
| "prebuild": "yarn types:check", | ||
| "types:check": "tsc --noEmit", | ||
| "build": "vite build && UMD=true vite build", | ||
| "cypress-open": "yarn dev 'cypress open'", | ||
| "dev": "concurrently 'cross-env PORT=8080 node test/e2e-server' vite", | ||
| "e2e": "yarn e2e-server 'cypress run'", | ||
| "e2e-server": "start-server-and-test 'cross-env PORT=8080 node test/e2e-server' 'http-get://localhost:8080/graphql?query={test { id }}'", | ||
| "prepublishOnly": "cp dist/index.umd.js graphiql.js && cp dist/index.umd.js.map graphiql.js.map && cp dist/index.umd.js graphiql.min.js && cp dist/index.umd.js.map graphiql.min.js.map && cp dist/style.css graphiql.css && cp dist/style.css graphiql.min.css", | ||
| "test": "vitest" | ||
| }, | ||
| "dependencies": { | ||
| "react-compiler-runtime": "19.0.0-beta-37ed2a7-20241206", | ||
| "@graphiql/react": "^0.28.0" | ||
| }, | ||
| "peerDependencies": { | ||
|
|
@@ -56,42 +58,28 @@ | |
| "react-dom": "^16.8.0 || ^17 || ^18" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-plugin-react-compiler": "19.0.0-beta-37ed2a7-20241206", | ||
| "vite-plugin-dts": "^4.3.0", | ||
| "vite-plugin-commonjs": "^0.10.4", | ||
| "vite": "^5.3.6", | ||
| "postcss-lightningcss": "^1.0.1", | ||
| "@vitejs/plugin-react": "^4.3.1", | ||
| "@graphiql/toolkit": "^0.11.0", | ||
| "@testing-library/jest-dom": "^6.6.3", | ||
| "@testing-library/react": "^16.1.0", | ||
| "cross-env": "^7.0.2", | ||
| "cypress": "^13.13.2", | ||
| "express": "^4.20.0", | ||
| "graphql": "^16.9.0", | ||
| "graphql-http": "^1.22.1", | ||
| "graphql-subscriptions": "^2.0.0", | ||
| "postcss": "8.4.31", | ||
| "postcss-import": "15.1.0", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "start-server-and-test": "^1.10.11", | ||
| "subscriptions-transport-ws": "0.11.0", | ||
| "typescript": "^4.6.3", | ||
| "ws": "8.17.1" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,9 @@ | ||
| module.exports = { | ||
| plugins: { | ||
| // https://github.com/postcss/postcss-import/issues/442#issuecomment-822427606 | ||
| 'postcss-import': '', | ||
| 'postcss-lightningcss': { | ||
| browsers: '>= .25%', | ||
| }, | ||
| }, | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be graphiql.js or else it will break all the unpkg implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by
it will break all the unpkg implementations?/dist/index.umd.js === /graphql.js
/dist/index.umd.js === /graphql.min.js