Loading spinner when running editor queries and fetching the schema #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,6 +200,10 @@ export class GraphiQL extends React.Component { | |||
|
|
|||
| componentDidMount() { | |||
| if (!this.state.schema) { | |||
| this.setState({ | |||
| showSpinner: true | |||
There was a problem hiding this comment.
We should only show a spinner when there is an user-produced query to the server underway, not for the automated fetching of the schema. GraphiQL is still usable without a schema, just typeahead and linters are not yet enabled, that's fine.
This implementation also has a race condition where we could issue a query before the schema returns. The schema would return and turn off the spinner, but the query itself hasn't returned yet.
|
You should also squash your commits together. You can do that with |
asiandrummer
force-pushed
the
spinner
branch
2 times, most recently
from
41540ec to
91cacea
Compare
|
|
| height: 36px; | ||
| width: 36px; | ||
| left: 50%; | ||
| transform: translate(-50%,-50%); |
There was a problem hiding this comment.
nit: space after the comma
asiandrummer
force-pushed
the
spinner
branch
from
e246db0 to
58f5ecc
Compare
asiandrummer
added a commit
that referenced
this pull request
Nov 30, 2015
Loading spinner when running editor queries and fetching the schema
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Jun 1, 2019
…babel-4.0.0 Update eslint-plugin-babel to the latest version 🚀
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Jun 5, 2019
Remove unused test files from main package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CSS-driven loading spinner when running editor queries and fetching the schema, in case they take a while. Shown in a result window and documentation explorer (since it needs a schema to be rendered).