fix: fixed invalid originalError propagation on parseValue() errors i…

…n custom scalars
graphql · Jan 29, 2023 · bdd24b7 · bdd24b7
1 parent 8be83d8
commit bdd24b7
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 1 deletion.
diff --git a/src/execution/__tests__/variables-test.ts b/src/execution/__tests__/variables-test.ts
@@ -5,6 +5,8 @@ import { expectJSON } from '../../__testUtils__/expectJSON.js';
 
 import { inspect } from '../../jsutils/inspect.js';
 
+import { GraphQLError } from '../../error/GraphQLError.js';
+
 import { Kind } from '../../language/kinds.js';
 import { parse } from '../../language/parser.js';
 
@@ -26,6 +28,25 @@ import { GraphQLSchema } from '../../type/schema.js';
 import { executeSync } from '../execute.js';
 import { getVariableValues } from '../values.js';
 
+const TestFaultyScalarGraphQLError = new GraphQLError(
+  'FaultyScalarErrorMessage',
+  {
+    extensions: {
+      code: 'FaultyScalarErrorMessageExtensionCode'
+    }
+  }
+);
+
+const TestFaultyScalar = new GraphQLScalarType({
+  name: 'FaultyScalar',
+  parseValue() {
+    throw TestFaultyScalarGraphQLError;
+  },
+  parseLiteral() {
+    throw TestFaultyScalarGraphQLError;
+  },
+});
+
 const TestComplexScalar = new GraphQLScalarType({
   name: 'ComplexScalar',
   parseValue(value) {
@@ -45,6 +66,7 @@ const TestInputObject = new GraphQLInputObjectType({
     b: { type: new GraphQLList(GraphQLString) },
     c: { type: new GraphQLNonNull(GraphQLString) },
     d: { type: TestComplexScalar },
+    e: { type: TestFaultyScalar }
   },
 });
 
@@ -225,6 +247,29 @@ describe('Execute: Handles inputs', () => {
           },
         });
       });
+
+      it('errors on faulty scalar type input', () => {
+        const result = executeQuery(`
+          {
+            fieldWithObjectInput(input: {c: "foo", e: "bar"})
+          }
+        `);
+
+        expectJSON(result).toDeepEqual({
+          data: {
+            fieldWithObjectInput: null,
+          },
+          errors: [
+            {
+              message:
+                'Argument "input" has invalid value { c: "foo", e: "bar" }.',
+              path: ['fieldWithObjectInput'],
+              locations: [{ line: 3, column: 41 }],
+            },
+          ],
+        });
+
+      });
     });
 
     describe('using variables', () => {
@@ -366,6 +411,22 @@ describe('Execute: Handles inputs', () => {
         });
       });
 
+      it('errors on faulty scalar type input', () => {
+        const params = { input: { c: 'foo', e: 'SerializedValue' } };
+        const result = executeQuery(doc, params);
+
+        expect(result.errors?.at(0)?.originalError).to.equal(TestFaultyScalarGraphQLError);
+        expectJSON(result).toDeepEqual({
+          errors: [
+            {
+              message: 'Variable "$input" got invalid value "SerializedValue" at "input.e"; FaultyScalarErrorMessage',
+              locations: [{ line: 2, column: 16 }],
+              extensions: { code: 'FaultyScalarErrorMessageExtensionCode' }
+            }
+          ]
+        });
+      });
+
       it('errors on null for nested non-null', () => {
         const params = { input: { a: 'foo', b: 'bar', c: null } };
         const result = executeQuery(doc, params);

diff --git a/src/execution/values.ts b/src/execution/values.ts
@@ -131,7 +131,7 @@ function coerceVariableValues(
         onError(
           new GraphQLError(prefix + '; ' + error.message, {
             nodes: varDefNode,
-            originalError: error.originalError,
+            originalError: error,
           }),
         );
       },