Apply suggestions from code review

graphql · Oct 17, 2024 · cdd0b55 · cdd0b55
1 parent f2a6e9d
commit cdd0b55
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/execution/__tests__/variables-test.ts b/src/execution/__tests__/variables-test.ts
@@ -96,11 +96,11 @@ const TestNestedInputObject = new GraphQLInputObjectType({
 
 const TestOneOfInputObject = new GraphQLInputObjectType({
   name: 'TestOneOfInputObject',
+  isOneOf: true,
   fields: {
     a: { type: GraphQLString },
     b: { type: GraphQLInt },
   },
-  isOneOf: true,
 });
 
 const TestEnum = new GraphQLEnumType({
@@ -1268,7 +1268,7 @@ describe('Execute: Handles inputs', () => {
       });
     });
 
-    it('errors with variable with no value', () => {
+    it('errors with variable object with no fields', () => {
       const result = executeQuery(
         `
           query ($input: TestOneOfInputObject) {
@@ -1289,7 +1289,7 @@ describe('Execute: Handles inputs', () => {
       });
     });
 
-    it('errors with variable with multiple values', () => {
+    it('errors with variable object with multiple fields', () => {
       const result = executeQuery(
         `
           query ($input: TestOneOfInputObject) {
@@ -1310,7 +1310,7 @@ describe('Execute: Handles inputs', () => {
       });
     });
 
-    it('errors with variable with single null value', () => {
+    it('errors with variable object with single null field', () => {
       const result = executeQuery(
         `
           query ($input: TestOneOfInputObject) {
@@ -1331,7 +1331,7 @@ describe('Execute: Handles inputs', () => {
       });
     });
 
-    it('errors with variable with multiple values, only one non-null', () => {
+    it('errors with variable object with multiple fields, only one non-null', () => {
       const result = executeQuery(
         `
           query ($input: TestOneOfInputObject) {

diff --git a/src/utilities/coerceInputValue.ts b/src/utilities/coerceInputValue.ts
@@ -135,7 +135,7 @@ function coerceInputValueImpl(
     }
 
     /**
-     * keys with the value "undefined" do not appear within the coerced input
+     * Keys with the value "undefined" do not appear within the coerced input
      * object, but do appear within the original input object.
      *
      * Note: in graphql-js, supplying the value "undefined" for a variable