Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export isValidNameError #1237

Merged
merged 5 commits into from
Feb 12, 2018
Merged

export isValidNameError #1237

merged 5 commits into from
Feb 12, 2018

Conversation

PatrickJS
Copy link
Contributor

@PatrickJS PatrickJS commented Feb 10, 2018 •
edited
Loading

PR mentioned in #1234 (comment)

Tipe CMS

@PatrickJS PatrickJS changed the title export assertValidName and isValidNameError export isValidNameError Feb 10, 2018
@mjmahone mjmahone merged commit f2534a1 into graphql:master Feb 12, 2018
@mjmahone
Copy link
Contributor

Thanks you! This seems like a useful export.

@PatrickJS PatrickJS deleted the patch-1 branch February 12, 2018 17:09
@IvanGoncharov
Copy link
Member

@mjmahone Thanks for merging this super useful function 👍
One suggestion: If you use "Squash and merge" option it will result in cleaner commit history, 1 vs 4 commits in this particular case.

This was referenced Mar 19, 2018
Open
Closed
Merged
Open
Closed
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatrickJS @mjmahone @IvanGoncharov @facebook-github-bot