Use .mjs for module code #1244
Merged
Use .mjs for module code #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we'll also need iterall to support mjs |
|
Is there a reason why the import { GraphQLError } from 'graphql/error' |
|
I've been trying to discourage keying deeply into the package contents, which should be implementation details, but you're right that it's no longer necessary if the files would have different extensions |
|
Just released https://github.com/leebyron/iterall/releases/tag/v1.2.0 which helps unblock this |
* Writes .mjs instead of .js for esmodules code. * Moves .mjs out of ./module into the top level since it no longer conflicts with .js Fixes #1217
4 tasks
This was referenced Mar 19, 2018
jaydenseric
added a commit
to jaydenseric/express-graphql
that referenced
this pull request
May 2, 2018
Relates to graphql#425. - Swapped deprecated babel-preset-es2015 for babel-preset-env. - Added package.json engines field. - Configured babel-preset-env to target the Node.js version defined in package.json engines field. - Kept Babel at v6, but moved config into a v7 ready .babelrc.js file for dynamic config via env. - Tidied the package.json scripts, added an ESM build step that generates .mjs dist files. Follow the lead of graphql/graphql-js#1244, although I do things quite different for my own projects with Babel v7. - Updated package.json main field for ESM/CJS cross compatibility. - Added a package.json module field for tree-shaking bundlers.
|
This broke bundling with webpack: #1536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217