Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark task #1251

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Benchmark task #1251

merged 1 commit into from
Feb 20, 2018

Conversation

leebyron
Copy link
Contributor

@leebyron leebyron commented Feb 16, 2018

This adds a benchmark task inspired by #1167 and #1163. Invoke with yarn benchmark.

Allows filtering down which benchmark to run, ala jest, and supplying which revisions to run against.

Closes #1167

This adds a benchmark task inspired by #1167 and #1163. Invoke with `yarn benchmark`.

Allows filtering down which benchmark to run, ala jest, and supplying which revisions to run against.
const BUILD_CMD = 'babel src --optional runtime --copy-files --out-dir dist/';
const LOCAL = 'local';
const LOCAL_DIR = path.join(__dirname, '../');
const TEMP_DIR = os.tmpdir();
Copy link
Member

@IvanGoncharov IvanGoncharov Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leebyron ~~~Both #1167 and #1163 were intended to enable benchmarking during development and it really inconvenient if after every small change you need to rebuild HEAD 😞~~~

I see you are using /tmp/graphql-js-benchmark, so no problem here 👍

@leebyron leebyron merged commit 8151240 into master Feb 20, 2018
@leebyron leebyron deleted the benchmark branch February 20, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants