-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
definition: replace object spread with explicit assignments #2089
Conversation
In preparation for graphql#1527
70de26a
to
e04d92b
Compare
Reflects changes in graphql#2089
Reflects changes in graphql#2089
Reflects changes in #2089
This is sort of a breaking change in practice. Because of the older spread-through, it was possible to define arbitrary other properties on fields, e.g. for https://github.com/4Catalyzer/graphql-validation-complexity#usage. This now no longer works. It's true that this was undocumented behavior, but I also don't think it was quite that rare in practice. |
@taion Can you please open an issue?
If there are devs stuck with this hack and can't switch to |
Fixes graphql#2114 Partly reverts graphql#2089
In preparation for #1527