Correct isSpecifiedScalarType refinement, fix #2153 #2194
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2153
Ran into this when looking to upgrade to the latest in graphql-nexus. To reproduce:
Before the changes in this PR,
type
in theelse
block is inferred to benever
, becauseisSpecifiedScalarType
is currently narrows to all scalars rather than just the "specified" ones, and as suchtype.name
is invalid:By adding the
& { name: '...' }
for each of the specified scalars, we give enough context to know that theelse
block is a valid codepath for all "non-specified" scalars.