Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildASTSchema ignores schema extensions #2246

Closed
wants to merge 1 commit into from
Closed

buildASTSchema ignores schema extensions #2246

wants to merge 1 commit into from

Conversation

mike-marcacci
Copy link
Contributor

While using graphql-js to check a sample schema for a blog post, I discovered that buildASTSchema completely ignores extension logic. I haven't had a chance to fix this yet, but just added failing test to show the current behavior.

I'll create a fix for this when I have time.

@mike-marcacci
Copy link
Contributor Author

Doh! It looks like this is already being discussed in #922 which I somehow missed... and @IvanGoncharov now has a WIP with #2248. Closing as duplicate.

@IvanGoncharov
Copy link
Member

@mike-marcacci Thanks for reporting 👍
It's one last issue I wanted to fix before feature freeze: #2199 (comment)
I did most of the preparation job in #2235 and just pushed WIP I have at the moment as #2248 (still missing some of the tests).
Also, it has a bunch any conversions but its something we can latter fix in the separate PRs.

@IvanGoncharov
Copy link
Member

@mike-marcacci Sorry for duplicating work.
Also, I need to figure out how to better distribute work in this repo in general.

@mike-marcacci
Copy link
Contributor Author

@IvanGoncharov - oh no worries at all! I didn't put much time into it at all... clearly not enough to even find the existing issue, haha.

Let me know if you want a second set of eyes on #2248!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants