Convert flow types to TS #2828
Closed
Convert flow types to TS #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I was asked to check in here. You are doing some serious transformations. Is there any way I can help out? ;) |
saihaj
force-pushed
the
migrate-to-ts
branch
2 times, most recently
from
0252608
to
e45a056
Compare
saihaj
force-pushed
the
migrate-to-ts
branch
2 times, most recently
from
caa8334
to
464cbf3
Compare
saihaj
commented
Nov 10, 2020
saihaj
force-pushed
the
migrate-to-ts
branch
2 times, most recently
from
23a8baa
to
79da01a
Compare
saihaj
force-pushed
the
migrate-to-ts
branch
2 times, most recently
from
50a97b9
to
bb270c2
Compare
|
@IvanGoncharov rebased this with |
| @@ -1 +1 @@ | |||
| export type PromiseOrValue<+T> = Promise<T> | T; | |||
| export type PromiseOrValue<T> = Promise<T> | T; | |||
There was a problem hiding this comment.
Note to myself: I need to check this commit.
saihaj
force-pushed
the
migrate-to-ts
branch
3 times, most recently
from
740ad83
to
446298c
Compare
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
Co-Authored-By: Kamil Kisiela <kamil.kisiela@gmail.com>
|
@saihaj That was a long journey thanks a lot for your help 👍 |
|
Congrats! When will this be released? |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert all the
.jsto.tsand fix all syntax related issues that exist because of Flow and TypeScript.%checksand removeeslint-disablecomments (saihaj@5d966bd)_saihaj@fbbb7a5#r43625283objectsince it is aWeakMap(saihaj@ae7c3f4#r43625385)integrationTests/*/**(saihaj@28023e6)?toMaybe(few were missed in 41b6975)mixedtounknown(few were missed in cd55ba9)$Keystokeyof$ReadOnlytoReadonly$ObjMaptoObjMaputility function (need help on this. See discussion here Convert flow types to TS #2828 (comment)).babelrc-denoto use TypeScriptAction items Based on #2828 (comment)
For @IvanGoncharov
visittypings in16.x.x16.x.xGraphQLAgregatedErrorFor @saihaj
Fix no redeclare(these will be removed so no need)src/polyfills/objectValues.ts