-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in node when mixing sync/async resolvers #3529
Fix crash in node when mixing sync/async resolvers #3529
Conversation
|
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @asztal, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
b391c2f
to
17ce540
Compare
17ce540
to
bc7049b
Compare
Hey @asztal can you please sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need similar logic when dealing with completion of lists?
7f14b8e
to
5bfb9d6
Compare
@asztal I fixed everything except CLA. |
Thanks! My contribution counts as a corporate contribution so I need a director to approve it for me first - it should be soon hopefully 🤞 |
Hi @asztal 👋 |
@IvanGoncharov et al, once this fix lands in |
@asztal - any word on the CLA? |
Sounds great 👍 |
The CLA manager at my company is having trouble using the Corporate CLA console -- I'm not at all familiar with it, so I've asked them to check they've signed up using the correct email address, otherwise just raise a support ticket about it like the message says. Sorry for the delay. Here's the actual error in case anyone here knows anything about it. |
@asztal Any news on CLA on your side? |
@asztal - any word on the CLA? |
Hi @chrskrchr Sorry about the delays, @asztal has since left and this one's fallen through the cracks a little. We're still chasing CLA approval, it's still stuck with the CLA approval but currently trying to find out if a ticket has been submitted |
@hobby203 can you try to rebase this and force push so the bot is happy? |
Hi @saihaj, I'm not sure if I can. This pr has been created from a fork under the developer's personal account, I don't think I'm able to do that. I could fork his fork and create a new PR, would that affect CLA approval? If it would I can try get in contact with @asztal and ask him to help out but would prefer not to bother him if possible. Best, |
Hopefully I'll have time to rebase the branch tonight. Thanks for getting the CLA sorted @hobby203 🙏 |
Hi all, Looks as though we're having issues with the CLA still. The EasyCLA tool won't approve it as @asztal doesn't have any commits on this project, but we know this to be the case as the fix is coming from their own fork and not from within the project. Is this something that's happened before? Not sure how to proceed. |
@hobby203 do you want to create PR with these changes and see if your CLA passes? |
@saihaj from inside this repo? or from my own fork, I checked but I can't create a new pr using these exact changes but i can try recreating the fix. |
@hobby203 - I'm happy to submit a new PR if you're tired of messing with this. I've got backports of this PR to the Just let me know... |
@chrskrchr - if everyone is happy with that I think it will be the best course of action. I'm not sure why we're having these problems but we are struggling to make progress on our end with this issue, so if it can be moved forward by taking another approach i'm more than happy to let that happen (: |
No problem! I'll go ahead and submit that new PR (giving credit to @asztal for the actual fix) and let the maintainers decide if they're OK with moving forward that way. |
A clone of this PR has been submitted as #3651. @saihaj @IvanGoncharov - can you please look at @hobby203's comment above that gives their blessing for this PR to be superseded by another PR to in order to move past the CLA issues? |
Sadly I can't be of much help with CLA bot 🥲 if the original author is fine having the PR from someone else I am fine moving forward with it. |
I'm fine with that, as long as the bug is fixed I'm happy. Apologies for the delays on my end. |
@asztal The CLA error "The commit (bc7049b). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket." normally indicates that there's an issue with your authorship details for the given commit. Please ensure that that commit is authored by the exact same email address that you have approved via the CLA. Here's some instructions on how to change the email address on that commit: |
Fixed by #3706 |
Fixes #3528
Ensures that if
executeFields
encounters a mix of promises and thrown errors, the promises will be awaited before throwing the error.This does technically change
executeFields
to return a rejected promise in this scenario as opposed to throwing the not-null error synchronously, but I figured if any of the resolvers are asynchronous then returning a promise will be expected anyway, and this was better than crashing the process.Note: I had to add an
unhandledRejection
event listener myself, as it seems mocha doesn't do it.