Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid @skip and @include directives in subscription root selection #3974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benjie
Copy link
Member

@benjie benjie commented Oct 9, 2023

This is an implementation of graphql/graphql-spec#860

The spec calls for a separate CollectSubscriptionFields algorithm due to executing without variableValues; but I figured that maintenance would be easier with the algorithms synchronized.

Please feel free to make any changes you need to this PR; it's just to get the ball rolling.

Related GraphQL WG action item (from 2021!): graphql/graphql-wg#695

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 57d7b11
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6524504013b5a90008d88b65
😎 Deploy Preview https://deploy-preview-3974--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@benjie benjie added the spec RFC Implementation of a proposed change to the GraphQL specification label Oct 9, 2023
@benjie
Copy link
Member Author

benjie commented Oct 9, 2023

GraphQL v17 would be a good time to add this "breaking change" @graphql/graphql-js-reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants