Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport(v16): Require non-empty directive locations (#4100) #4137

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Jul 1, 2024

Backport's #4100 and #4130 into 16.x.x branch.

Copy link

github-actions bot commented Jul 1, 2024

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@benjie
Copy link
Member Author

benjie commented Jul 1, 2024

That's weird... CI didn't run. Closing and reopening.

@benjie benjie closed this Jul 1, 2024
@benjie benjie reopened this Jul 1, 2024
@benjie benjie closed this Jul 1, 2024
@benjie benjie reopened this Jul 1, 2024
@benjie
Copy link
Member Author

benjie commented Jul 1, 2024

All sorted. Had to fix the codecov setup.

@benjie benjie merged commit 993d7ce into 16.x.x Sep 18, 2024
32 checks passed
@benjie benjie deleted the 16-backports branch September 18, 2024 16:47
@yaacovCR yaacovCR added PR: feature 🚀 requires increase of "minor" version number PR: bug fix 🐞 requires increase of "patch" version number and removed PR: feature 🚀 requires increase of "minor" version number labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants